gonzedge / rambling-trie / #393

100%

master: 100%

push

Allow `Nodes::Node`s to hold arbitrary `value`s (#85)

Allow `Nodes::Node`s to hold arbitrary `value`s! Now, you can have a
terminal node that on top of representing its word, it can hold on to

- Add `value` attribute to `Nodes::Node`
- Add optional, nilable `value` argument to `Container#add`,
`Nodes::Node#add`
- Store given `value` in terminal node via `Nodes::Raw#add` and
`Nodes::Raw#add_to_children_tree`, when present
- Update `Compressor#merge` and `Compressor#compress_children_and_copy`
to store `value` from `Nodes::Raw` in the
  terminal `Nodes::Compressed`, when present
- Add optional `values` array argument to `Container#concat`
corresponding 1:1 to `words`, that passes each word and
  value to `#add` when present
- Add `value` to `Inspectable#inspect` output, when present
- Add generic type `TValue` to `Nodes::Node` type signature
  - Extract `_Nilable` interface to own top-level file
- Make `value` attribute in `Nodes::Node` use the new `TValue` generic
type
  - Allow `TValue` to be `nil` by default with `?`
- Require `TValue` to implement `_Inspect` built-in(!) interface, for
`Inspectable` module
- Change all types that depend on `Nodes::Node` also have the generic
type `TValue < _Inspect`
    including static methods
- Add optional `TValue` argument to `Container#add`, `Nodes::Node#add`,
and `Nodes::Raw#add_to_children_tree`
  - Add optional `Array[TValue?]` argument to `Container#concat`
- Add new `|| raise`s because the inline type conversion to non-nil
doesn't work anymore for `steep` check 🤷🏻‍♂
- Make compatible with `rbs` `v3.7.0` and `steep` `v1.9.0`
  -  Change `ProviderCollection#[]` to return TProvider?
  - Change `Nodes::Node#[]` to return Nodes::Node[TValue]?
  - Change `Container#[]` to return Nodes::Node[TValue]?
  - Add type annotations for `UnannotatedEmptyCollection`s
- Raise `InvalidOperation`s when `compress(child)` return nil value
which is not supposed to be possible

31 of 31 new or added lines in 7 files covered. (100.0%)

550 of 550 relevant lines covered (100.0%)

1370.17 hits per line