trixi-framework / TrixiAtmo.jl / 12202227359

97%

push

github

[2D manifold in 3D] Option to use global Cartesian coordinates to define exact covariant basis vectors (#54)

* new save_solution_file method for covariant form

* save using conversion that depends on auxiliary variables

* improve comment

* move back spherical2cartesian

* generalize metrics

* covariant form using polynomial geometry, but it isn't conservative

* a_node -> aux_node

* remove duplicated code and HDF5 dependency

* remove using HDF5...

* add third contravariant component to have consistent number of variables

* ability to choose between exact geometry in spherical coords or approx cartesian

* preliminary implementation of exact cartesian global coordinates

* now have option to switch between spherical/cartesian global coords

* resolve merge

* make integrate_via_indices use exact Jacobian

* fix initial condition

* update docstrings

* remove HDF5 and Infiltrator

* remove

* add more docstrings

* resolve conflicts

* improve comments

* more docstring/comments

* put back in comment about bottom topography being zero for initial_condition_gaussian

* add comment about calc_node_coordinates

* remove unnecessary calc_node_coordinates_2d_shell

* remove git add .! from end of docstring warning

* improve docstring

* remove obsolete comment

* Added elixirs for spherical advection convergence tests

* use same save_solution_file as Cartesian

* remove v3

* fix tests

* remove references to v3 in comments

* fix typo in docstring

* Apply suggestions from code review

Co-authored-by: Andrés Rueda-Ramírez <aruedara@uni-koeln.de>

* apply suggestions from code review

---------

Co-authored-by: Andrés Rueda-Ramírez <aruedara@uni-koeln.de>

106 of 108 new or added lines in 7 files covered. (98.15%)

1613 of 1803 relevant lines covered (89.46%)

1584620.07 hits per line