Ran
|
Jobs
1
|
Files
518
|
Run time
2min
|
Badge
Embed ▾
README BADGES
|
push
github
config: fix schema:get()/set() changes passed path This patch makes `schema:get()`, `schema:set()` and `config:get()` not change the passed path argument when it is a table. The problem was in the way the walkthrough process is set up during the `schema:get()` and `schema:set()` method execution. These methods used `walkthrough_start()` performing a shallow copy of the passed option table containing the information on the desired path. The value of the path was modified during the walkthrough itself. The patch makes the methods perform a shallow copy of the path field. It also fixes `config:get()` since it's internally uses `schema:get()`. This is how broken scenario could be reproduced when using `config:get()`: ``` tarantool> config = require('config') tarantool> path = {'fiber', 'slice'} tarantool> config:get(path) --- - err: 1 warn: 0.5 ... tarantool> path --- - [] ... ``` Closes #10855 NO_DOC=bugfix (cherry picked from commit fb5740cae)
69618 of 123486 branches covered (56.38%)
102563 of 117450 relevant lines covered (87.32%)
2944960.45 hits per line
Lines | Coverage | ∆ | File |
---|---|---|---|
1 |
95.78 |
-0.12% | src/box/replication.cc |
1 |
93.66 |
-0.14% | src/box/txn_limbo.c |
1 |
92.2 |
0.05% | src/box/vinyl.c |
2 |
95.45 |
-4.55% | src/lib/json/json.h |
2 |
84.31 |
-0.1% | src/box/xlog.c |
2 |
87.6 |
-0.14% | src/box/vy_run.c |
2 |
82.22 |
-4.44% | src/lib/core/latch.h |
2 |
85.71 |
-9.52% | src/lib/core/tt_sigaction.c |
3 |
90.7 |
-0.22% | src/box/applier.cc |
3 |
94.68 |
-1.6% | src/box/vy_range.c |
4 |
81.82 |
-12.12% | src/lua/minifio.c |
4 |
22.62 |
-0.08% | src/lib/uri/uri_parser.c |
5 |
90.88 |
-0.16% | src/box/box.cc |
7 |
94.55 |
-1.47% | src/box/vy_read_iterator.c |
8 |
60.84 |
-3.13% | src/lib/core/fio.c |
9 |
88.14 |
-7.63% | src/box/vy_regulator.c |
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
1 | 12180976347.1 | 518 |
87.32 |
GitHub Action Run |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
---|