btcsuite / btcd / 12174808993

57%

master: 55%

Build Type

Pull #2269

github

Committed by same-id

Commit Message

Fix non-root hosts failing on resolving DNS

A fix for a bug introduced by #2168

Previously, config.Host worked in the following way:
1. Documented as supporting ip addresses only
2. In fact supported "host/path" syntax
3. Did not support "scheme" prefixes, i.e. https://

Not sure this is the desired approach, probably the best thing would
have been to extend config to contain "Scheme" and "Path" fields as well.

However, this was the way it worked.

1. Now Host can contain scheme prefixes "unix://..."
2. Host can no longer contain ".../path"

This PR solves this behavior while maintaining support of the "unix://" flow
as well.

For some reason, "scheme" is named "network" in #2168 - I did not change that.

Also remove disambiguation in "network:address:port", where it parsed
"myhost:8888" as network:address instead address:port.

Pull Request Pull Request #2269: Fix non-root hosts failing on resolving DNS

Run Details

22 of 50 new or added lines in 1 file covered. (44.0%)

2 existing lines in 1 file now uncovered.

29911 of 52217 relevant lines covered (57.28%)

424670.71 hits per line