12165456071
80%

Ran 04 Dec 2024 05:52PM UTC

Jobs 1

Files 37

Run time 1min

Badge

Embed ▾

Committed 04 Dec 2024 05:40PM UTC coverage: 78.273%. Remained the same

Build # 12165456071

Build Type

push

github

Committed by

web-flow

Commit Message

CA-401075: remove misleading logs from HTTP client (#6158)

Recent changes to Http_client were made to log errors and backtraces in
case of unusual errors, in order to better diagnose problems.
Unfortunately, this also led to benign exceptions being logged, which
caused people to suspect problems where the exception was actually
"expected". In particular the following error started appearing in the
logs many times:

    Raised Http_client.Parse_error("Expected initial header []")

The case here is that the client has sent an HTTP request, but the
server disconnects before sending a response.

It turns out that this happens commonly when an external connection is
received by xapi and handed over to another process, such as xcp-rrdd.
The connection's file descriptor is passed to the other process, and the
original HTTP request is forwarded over a local socket. The other
process continues to handle the request and sends responses to the
forwarded socket, but never to the local socket, where xapi is waiting
for the response.

This is a quick change that makes the caller of the receive function
aware that no response was sent, without logging scary errors, to fix
the immediate problem. In addition, we should enhance the handover
process to actually send responses, although funcionally this is not an
issue.

Run Details

3462 of 4423 relevant lines covered (78.27%)

0.78 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	python3.11 - 12165456071.1	04 Dec 2024 05:52PM UTC	37	78.27	GitHub Action Run

xapi-project / xen-api / 12165456071
80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12165456071

xapi-project / xen-api / 12165456071 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12165456071

xapi-project / xen-api / 12165456071
80%

README BADGES
x