facebookincubator / TTPForge / 12158653895

64%

main: 67%

Pull #520

github

Use smart buffering (#520)

Summary:

when reading the subprocess stdout to prevent extra new lines in output

Inspired by https://github.com/uber-go/zap/blob/0ba452dbe/zapio/writer.go#L100

---
ttpforge reads stdout/stderr inaccurately causing such lines in logs:

```
INFO	[STDERR] curl: (56) Received HTT
INFO	[STDERR] P code 407 from proxy after CONNECT
```
the code: https://fburl.com/code/52hzjy4j

Differential Revision: D66702400

43 of 43 new or added lines in 1 file covered. (100.0%)

1848 of 2878 relevant lines covered (64.21%)

14.34 hits per line