tarantool / tarantool / 12157066644

88%

push

github

box: drop long select warning

There's a better mechanism for detecting stalled fibers - fiber slice.
It first logs a warning if a fiber doesn't yield for too long, then
kills the fiber. The long select warning was added before the fiber
slice feature was introduced. Initially, it was pretty annoying so
we had to improve it over the time. For example, we disabled it for
system spaces and introduced the "fullscan" option to suppress it.

Recently, select with offset became fast, see commit 421d36f2e144
("memtx: accelerate select with offset in tree") but we still log
the warning if the offset is > 1000. Instead of fixing this feature
once again, let's accept that it's useless and finally drop it.

This commit drops the Lua log ratelimiter along the way because it
isn't used anywhere else or covered by any tests, but doesn't remove
"fullscan" option usage from tests - the option is silently ignored now.

This commit effectively rolls back the following commits:
 - commit 9b7467d1e05e5 ("lua: introduce `Ratelimit` class")
 - commit 7aa02f302d819 ("box: log dangerous `select` calls")
 - commit 29654ffe3638e ("box: improve check for dangerous `select`
   calls")
 - commit 4221a983ffea2 ("box: refactor `check_select_safety` and add it
   to `box.internal`")

NO_DOC=feature hasn't been documented yet;
       doc tickets will be closed manually

69644 of 123486 branches covered (56.4%)

102611 of 117449 relevant lines covered (87.37%)

2899286.1 hits per line