12157353733
76%

Ran 04 Dec 2024 10:03AM UTC

Jobs 14

Files 229

Run time 1min

Badge

Embed ▾

Committed 04 Dec 2024 10:01AM UTC coverage: 88.923% (+0.06%) from 88.86%

Build # 12157353733

Build Type

push

github

Committed by

web-flow

Commit Message

[native_assets_builder] Don't cache hook invocations if env vars change (#1759)

This PR makes the native assets builder save the `Platform.environment` a hook is run in. Subsequent invocations check if the environment didn't change.

This removes the `includeParentEnvironment` parameter everywhere. It was always set to true in `dartdev` and `flutter_tools` (This will require a manual roll into the Dart SDK and Flutter tools.)

A follow up PR should restrict the list of environment variables (https://github.com/dart-lang/native/pull/1764), this PR is about caching correctness.

Bug: 

* https://github.com/dart-lang/native/issues/32

Run Details

52 of 54 new or added lines in 3 files covered. (96.3%)

11833 of 13307 relevant lines covered (88.92%)

34.79 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
2	97.03	-1.52%	pkgs/native_assets_builder/lib/src/dependencies_hash_file/dependencies_hash_file.dart

Subprojects

ID	Flag name	Job ID	Ran	Files	Coverage
6	native_assets_builder_ubuntu	12157353733.6	04 Dec 2024 10:07AM UTC	11	90.96	GitHub Action Run
7	native_assets_cli_windows	12157353733.7	04 Dec 2024 10:04AM UTC	30	76.95	GitHub Action Run
8	native_assets_builder_macos	12157353733.8	04 Dec 2024 10:07AM UTC	11	90.96	GitHub Action Run
9	native_toolchain_c_windows	12157353733.9	04 Dec 2024 10:06AM UTC	25	79.01	GitHub Action Run
10	native_assets_builder_windows	12157353733.10	04 Dec 2024 10:09AM UTC	11	90.96	GitHub Action Run
11	native_toolchain_c_ubuntu	12157353733.11	04 Dec 2024 10:03AM UTC	25	74.49	GitHub Action Run
12	native_assets_cli_ubuntu	12157353733.12	04 Dec 2024 10:04AM UTC	30	77.29	GitHub Action Run
13	native_assets_cli_macos	12157353733.13	04 Dec 2024 10:03AM UTC	30	77.29	GitHub Action Run
14	native_toolchain_c_macos	12157353733.14	04 Dec 2024 10:03AM UTC	25	69.89	GitHub Action Run
14	swift2objc	12149584499.14	03 Dec 2024 10:57PM UTC	39	88.09	GitHub Action Run
2	ffigen	11849122173.2	15 Nov 2024 02:35AM UTC	72	91.46	GitHub Action Run
14	objective_c	12150104634.14	03 Dec 2024 11:46PM UTC	73	78.31	GitHub Action Run
13	jnigen	12090369299.13	29 Nov 2024 08:45PM UTC	21	90.35	GitHub Action Run
14	jni	12090369299.14	29 Nov 2024 08:40PM UTC	30	75.5	GitHub Action Run

dart-lang / native / 12157353733
76%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Subprojects

Source Files on build 12157353733

dart-lang / native / 12157353733 76%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Subprojects

Source Files on build 12157353733

dart-lang / native / 12157353733
76%

README BADGES
x