payjoin / rust-payjoin / 12131447448

83%

Build Type

push

github

Committed by DanGould

Commit Message

Qr optimizations (#417)

These commits:

1. encode fragment paramters as bech32 strings (with no checksum), with
  2 character param names in the human readable part, and `+` as a
  delimiter
  - expiry time parameter encoded as a little endian u32, in line with
    bitcoin header timestamp and unix time nLocktime encoding. `EX` hrp
  - ohttp has `OH` hrp, same byte representation as previously encoded in
    base64
  - receiver key has `RK` hrp, same byte representation as previously
    encoded in base64
2. use bech32 with no human readable part for the subdirectory IDs
3. uppercase the scheme and host of the URI
4. move the pj so it follows the pjos parameter

Once the `#` %-escaping bug is fixed (see #373), and as long as no path
elements between the host and the subdirectory ID, the entire `pj`
parameter of the bip21 URI can be encoded in a QR using the alphanumeric
mode. Closes #389.

The last commit seems sufficiently motivated. Since there is no purpose
to clearing these values it doesn't actually simplify the code that much.

Manually verified, with manual % escaping of `#`, using the `qrencode`
CLI encoder alphanumeric mode is indeed used for everything following
`pj=`.

Run Details

177 of 201 new or added lines in 9 files covered. (88.06%)

5 existing lines in 3 files now uncovered.

2857 of 4624 relevant lines covered (61.79%)

995.36 hits per line