PHPCSStandards / PHP_CodeSniffer / 12129060558

78%

master: 79%

push

github

Generic/CyclomaticComplexity: ensure the sniff bails if `scope_closer` is not set

Quoting @jrfnl: "Only checking for the scope_opener, when
accessing/using both the scope_opener and scope_closer indexes, is
probably fine in practical terms. However, the part of the code base
which sets these indexes is not sufficiently covered by tests, nor does
it document that those indexes will only be set if both can be set, so
there may be edge case exceptions" (https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/684#discussion_r1865313147).

The sniff was already working fine before this change. Checking if
`scope_closer` is just an extra precaution to err on the side of caution.

1 of 1 new or added line in 1 file covered. (100.0%)

18859 of 24580 relevant lines covered (76.72%)

75.45 hits per line