terrapower / armi / 12128309580

90%

master: 87%

push

github

Improving getOptimalAssemblyOrientation (#2019)

Improving  getOptimalAssemblyOrientation

The algorithm goes as follows:

1. Get all the pin powers and `IndexLocation`s from the block at the
   previous location
2. Obtain the `IndexLocation` of the pin with the highest burnup
3. For each possible rotation,
   - Find the new location with `HexGrid.rotateIndex`
   - Find the index where that location occurs in previous locations
   - Find the previous power at that location
4. Return the rotation with the lowest previous power

This algorithm assumes a few things:

1. `len(pinLocations) == len(pinPowers)` in both cases. This may make
   sense, but we've found some cases where this assumption breaks. Not
   even edge cases, like the C5G7 LWR benchmark.
2. Your assembly has at least 60 degree symmetry of fuel pins and
   powers. This means if we find a fuel pin with high burnup and rotate
   it 60 degrees, there should be another fuel pin at that lattice site.
   This is mostly a safe assumption since many hexagonal reactors have
   at least 60 degree symmetry of fuel pin layout. This assumption holds
   if you have a full hexagonal lattice of fuel pins as well.

---------

Co-authored-by: John Stilley <1831479+john-science@users.noreply.github.com>

100 of 107 new or added lines in 4 files covered. (93.46%)

27338 of 30290 relevant lines covered (90.25%)

0.9 hits per line