gonzedge / rambling-trie / #344

100%

master: 100%

push

Add reek + codeclimate plugin + lint-reek GH action (#67)

- Add `reek` gem, exclude `tasks` and `spec` from checks
- Add `.reek.yml` with exclusions
- Add `lint-reek` GitHub action

Code smells addressed:
- Use `return unless variable` instead of `return if variable.nil?`
where appropriate, since nil check is a type check
- Extract `size` variable for `chars.length - 1` in
`Container#words_within_root`
- Extract `entry_name` for `entry.name` in `Serializers::Zip`
- Use longer variable names within blocks (`char` in
`Container#words_within_root`; `extension`, `provider` in
`ProviderCollection#reset`) or remove altogether `p` in
`ProviderCollection#contains?`

Also:

- Assign `child.parent` to `self` in all of `children_tree` during
`Nodes::Compressed#initialize`
- Simplify `Compressor#merge`
- Rename `Compressor#compress{,_only}_child_and_merge`

27 of 27 new or added lines in 5 files covered. (100.0%)

548 of 548 relevant lines covered (100.0%)

1349.32 hits per line