rust-bitcoin / rust-bitcoin / 12088604644

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3681: hashes: Documents C-QUESTION-MARK

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/91268bba672d7dea9e29cccfa83f3b34df27fe91">91268bba6 Examples use ?, not try!, not unwrap (Jamil Lambert, PhD)

Pull request description:

  To conform to Rust API guidelines in Issue #3633 examples should use ?, not try!, not unwrap (C-QUESTION-MARK).

  The examples were originally labelled `## Commonly used operations`, change the label to `# Examples`.
  Replace `unwrap()` with `expect()` since these cases cannot error.

  Two uses of `unwrap()` have been left since they are in a set of three writes with an engine that can not error and the first case uses `expect()` with the relevant error message.

ACKs for top commit:
  tcharding:
    ACK 91268bba672d7dea9e29cccfa83f3b34df27fe91
  sanket1729:
    ACK 91268bba672d7dea9e29cccfa83f3b34df27fe91
  apoelstra:
    ACK 91268bba672d7dea9e29cccfa83f3b34df27fe91; successfully ran local tests

Tree-SHA512: 4c7836b2e7062bda3986bd7cebd7b8c3dc8

20183 of 24365 relevant lines covered (82.84%)

17827.97 hits per line