rust-bitcoin / rust-bitcoin / 12072660244

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3672: units: Remove serde from amounts

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/77085a1fa1f39e7358202e49189282e48a965747">77085a1fa units: Remove serde from amounts (Tobin C. Harding)

Pull request description:

  The `Amount` and `SignedAmount` were not supposed to implement `serde` traits by design because doing so implicitly uses sats. We provide two modules `as_sat` and `as_btc` to allow users to explicitly serialize in their preferred format.

  In commit: `d57ec019d5 Use Amount type for TxOut value field` derives were added for `serde` and we did not notice it during review.

ACKs for top commit:
  apoelstra:
    ACK 77085a1fa1f39e7358202e49189282e48a965747; successfully ran local tests

Tree-SHA512: ff4c1f3416f95eb334d53fb0b1ce73c1c17

20134 of 24320 relevant lines covered (82.79%)

17930.98 hits per line