PHPCSStandards / PHP_CodeSniffer / 12057684915

78%

master: 79%

push

github

Generic/OpeningFunctionBraceKernighanRitchie: improve error message

Follow up on 707

When there are multiple tabs between the end of the function signature and the open brace, the "found: $length" part of the error message would refer to the number of tabs found.

This is inconsistent with other sniffs and confusing.

This commit fixes this, while still maintaining the previous behaviour - as introduced via https://github.com/squizlabs/PHP_CodeSniffer/commit/c4b9807cd - of special casing the messaging for a single tab - independently of whether or not tab replacement is in effect.

Example for line 10 of test case file 2:
```
// Before:
Expected 1 space before opening brace; found 3

// After:
Expected 1 space before opening brace; found 11
```

Covered via pre-existing tests in both test case files + some additional new tests.

5 of 5 new or added lines in 1 file covered. (100.0%)

18755 of 24582 relevant lines covered (76.3%)

75.34 hits per line