tarantool / tarantool / 12047773762

88%

Build Type

push

github

Committed by sergepetrenko

Commit Message

replication: do not account booting replicas in sync quorum

With `bootstrap_strategy ~= 'legacy'` all replicas to which a node
managed to connect enter the pool of nodes with which the node has to
sync before leaving orphan mode.

This leads to inability to add new replicas to the cluster with
centralized configuration: if master manages to connect to some of the
new replicas before they are joined, it considers them part of sync
quorum and enters orphan mode. The nodes cannot be joined, because
master is read only, and master remains read only, because it can't sync
with a not yet booted node.

Let's fix this and not account connected but not yet booted nodes in
sync quorum.

Also fix the gh_10087 and gh_10088 tests. They started failing after the
patch because one of the replicas started becoming writable earlier,
before the other replica was bootstrapped. This made the other replica
occasionally bootstrap from it instead of bootstrapping from master.
Such situation was possible even before the patch, if one of the
replicas timed out waiting for the other to start, but was really
unlikely to happen, so the test wasn't ready for it.

Closes #10760

NO_DOC=bugfix

Run Details

69502 of 123324 branches covered (56.36%)

10 of 10 new or added lines in 2 files covered. (100.0%)

17 existing lines in 9 files now uncovered.

102429 of 117262 relevant lines covered (87.35%)

2717791.65 hits per line