babelfish-for-postgresql / babelfish_extensions / 12036365292

74%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Fix resetting some GUCs at the time of TDSResetConnection (#3163)

Some GUCs had an issue with being reset at time of TDSResetConnection:

1. Explain GUCs, they were not getting setting reset after TDSResetConnection. To fix this we need to reset it at time TDSResetConnection AND also at time of sys.sp_reset_connection execution(which would otherwise have given explain output).
2. ANSI_DEFAULTS and IMPLICIT_TRANSACTION related GUCs. These were getting set when driver sends some TDS flags. But after ResetConnection they were being rolled-back. To avoid this we implement TdsResetLoginFlags a wrapper to Re-ProcessLoginFlags.
3. We restrict the setting and re-setting of important GUCs like "babelfishpg_tsql.migration_mode" and "role", since once set, cannot be reset.

Issues Resolved:
BABEL-5280, BABEL-5276, BABEL-5278

Signed-off-by: Kushaal Shroff <kushaal@amazon.com>

Run Details

12 of 12 new or added lines in 5 files covered. (100.0%)

77 existing lines in 3 files now uncovered.

43085 of 58476 relevant lines covered (73.68%)

142215.77 hits per line