amazon-aurora / babelfish_extensions / 12030687206

75%

main: 77%

push

github

Fix Identity columns not being recognized during DML statements using OUTPUT and WHERE clause (#3146)

Earlier when we executed DML queries that had OUTPUT clause along with a WHERE in the OUTPUT'ed query, we didnt expand the target list of this OUTPUT'ed query properly when the target list was not provided by user.
For example:
"UPDATE t1 SET TEXTVal = 'NewValue' OUTPUT Inserted.ID, Inserted.TEXTVal, Deleted.ID, Deleted.TEXTVal INTO t2 WHERE ID IN (1,2)" table t2's target list will be created during analyze phase and we were not ignoring the identity/computed columns while expanding the list.
With this commit we fix this by ignoring any identity/computed columns at the time of target-list fetch.

Tasks:
BABEL-5432

Signed-off-by: Kushaal Shroff <kushaal@amazon.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

46393 of 62081 relevant lines covered (74.73%)

161175.37 hits per line