mindersec / minder / 12012465157

58%

Build Type

push

github

Committed by web-flow

Commit Message

Migrate trusty eval engine to Trusty v2 API. (#5013)

* Migrate trusty eval engine to Trusty v2 API.

This change migrates `trusty` evaluation engine to use Trusty v2
API. Most of the changes apply to the intermediate representation we
recently added to decouple Trusty from Minder, but some additional
changes were required due to some fields becoming optional and
nullable.

Note: this change is again meant to be bug-compatible with the current
evaluation engine, so we treat the lack of `"score"` as a score of
`0`, thus triggering false positives as done by the current
engine. The idea is to build on top of this to fix known issues of the
engine before migrating it to Data Sources.

Fixes stacklok/minder-stories#77

* Refactor package comparison in a separate routine.

* Address PR comments.

Run Details

29 of 141 new or added lines in 2 files covered. (20.57%)

4 existing lines in 2 files now uncovered.

15870 of 29162 relevant lines covered (54.42%)

39.34 hits per line