rust-bitcoin / rust-bitcoin / 12010556517

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3640: address: Add `Address::into_unchecked`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/073ff81536e7a24883d6470ecf3054f4b7263186">073ff8153<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2a9400434155056bfd73462827dba1da5a10bc6d"> address: Simplify `Address::assume_checked` impl (Max Fang)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/e4cf8ebc208068ef2888e6e9e6f27f12cd07570f">e4cf8ebc2</a> address: Add `Address::into_unchecked` (Max Fang)

Pull request description:

  ## Commits

  ### address: Add `Address::into_unchecked`

  Adds an ergonomic way to convert any `Address` (network can be checked
  or unchecked) into an `Address<NetworkUnchecked>` without cloning, which
  I've found useful in several contexts.

  ### address: Simplify `Address::assume_checked` impl

  Removes an unnecessary `match` which I noticed while implementing `Address::into_unchecked`.

  ## Small note on use of `Self`

  The style guide in `CONTRIBUTING.md` notes to return `Self` when possible, but that doesn't apply here as the `Address` being returned is different from the `Address` type referred to by `Self`, due to the changed `NetworkValidation` type.

ACKs for top commit:
  tcharding:
    ACK 073ff81536e7a24883d6470ecf3054f4b7263186
  apoelstra:
    ACK 073ff81536e7a24883d6470ecf3054f4b7263186; successfully ran local tests; nice!

Tree-SHA512: dd6749cfff4b1b38fa81a5db4b10de0be4b

1 of 2 new or added lines in 1 file covered. (50.0%)

20055 of 24294 relevant lines covered (82.55%)

17932.92 hits per line