sebnitu / vrembem / 12000855875

94%

main: 100%

push

github

Refactor and simplify PluginsArray and decouple from Collections logic (#2126)

This PR refactors some of the logic in PluginsArray and the plugins system in general. This includes the following changes:

- Creates a new modules director for storing more complex pieces of code that don't align well with the helpers/utility categories. This includes:
  - `eventEmitter`
  - `FocusTrap`
  - `localStore`
  - `PluginsArray`
- Removes the ability to pass lifecycle hooks through a plugins options argument.
- Removes the ability to pass name property through a plugins options argument.
- Plugin add/remove methods are now part of a collections `mount` and `unmount` lifecycles. The constructor now only creates the plugins property using `PluginsArray`.
- Created defaults export for Collections.
- Removed `setupPluginObject` and incorporated logic into `PluginsArray` module.
- Renamed plugins `config` property to `options` for consistency.
- Moved component plugin presets from plugins into component files.
- Removed `teardown` methods of plugins when the `onDestroyEntry` hooks sufficed. 
- Plugins option should always be an array.

679 of 679 branches covered (100.0%)

Branch coverage included in aggregate %.

99 of 99 new or added lines in 12 files covered. (100.0%)

2541 of 2541 relevant lines covered (100.0%)

140.35 hits per line