kubevirt / containerized-data-importer / #5026

49%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

CNV-51521 | Fix Incomplete transfer of change blocks leads to data corruption (#3534)

* CNV-51521 | Fix Incomplete transfer of change blocks leads to data corruption

Issue: When user has a large disk with over 2000 changed blocks the
QueryChangedDiskAreas returns only first 2000 changed blocks. The disk
is not getting all the changes form the VMware Change Block Tracking and
this can cause disk corruption.

Fix: Query the changed areas by every 2000 block chunks, combine the chunks
together and request the next QueryChangedDiskAreas to start from the
end of the last block. Once the QueryChangedDiskAreas will return less
than 2000 blocks we know that it was the last chunk and can continue
with the disk import.

Ref: https://issues.redhat.com/browse/CNV-51521

Signed-off-by: Martin Necas <mnecas@redhat.com>

* Fix unit tests for new changed block query behavior.

* Fix unit tests for new changed block query behavior.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Fix lint failure.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

---------

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Get VDDK warm import tests working.

Change the QueryChangedDiskAreas loop to always quit on zero-length
change lists. The previous condition would spin forever when vcsim
returned 0 for every request.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Add a limit for the disk capacity before querying the changed blocks

Issue: When running the QueryChangedDiskAreas with startOffset of the
disk size we would get following erorr.
```
Failed to query changed areas: ServerFaultCode: A specified parameter was not correct: startOffset
```

Fix: Add query to get the VMware disk size to compare the offset and the
disk size.

Signed-off-by: Martin Necas <mnecas@redhat.com>

---------

Signed-off-by: Martin Necas <mnecas@redhat.com>
Signed-off-by: Matthew Arnold <marnold@redhat.com>
Co-authored-by: Matthew Arnold <5075485+mrnold@users.noreply.git... (continued)

Run Details

42 of 57 new or added lines in 1 file covered. (73.68%)

11 existing lines in 1 file now uncovered.

16735 of 28221 relevant lines covered (59.3%)

0.66 hits per line