• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubevirt / containerized-data-importer / #5026
49%

Build:
DEFAULT BRANCH: main
Ran 21 Nov 2024 11:55PM UTC
Jobs 1
Files 156
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

21 Nov 2024 11:45PM UTC coverage: 59.3% (+0.002%) from 59.298%
#5026

push

travis-ci

web-flow
CNV-51521 | Fix Incomplete transfer of change blocks leads to data corruption (#3534)

* CNV-51521 | Fix Incomplete transfer of change blocks leads to data corruption

Issue: When user has a large disk with over 2000 changed blocks the
QueryChangedDiskAreas returns only first 2000 changed blocks. The disk
is not getting all the changes form the VMware Change Block Tracking and
this can cause disk corruption.

Fix: Query the changed areas by every 2000 block chunks, combine the chunks
together and request the next QueryChangedDiskAreas to start from the
end of the last block. Once the QueryChangedDiskAreas will return less
than 2000 blocks we know that it was the last chunk and can continue
with the disk import.

Ref: https://issues.redhat.com/browse/CNV-51521

Signed-off-by: Martin Necas <mnecas@redhat.com>

* Fix unit tests for new changed block query behavior.

* Fix unit tests for new changed block query behavior.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Fix lint failure.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

---------

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Get VDDK warm import tests working.

Change the QueryChangedDiskAreas loop to always quit on zero-length
change lists. The previous condition would spin forever when vcsim
returned 0 for every request.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Add a limit for the disk capacity before querying the changed blocks

Issue: When running the QueryChangedDiskAreas with startOffset of the
disk size we would get following erorr.
```
Failed to query changed areas: ServerFaultCode: A specified parameter was not correct: startOffset
```

Fix: Add query to get the VMware disk size to compare the offset and the
disk size.

Signed-off-by: Martin Necas <mnecas@redhat.com>

---------

Signed-off-by: Martin Necas <mnecas@redhat.com>
Signed-off-by: Matthew Arnold <marnold@redhat.com>
Co-authored-by: Matthew Arnold <5075485+mrnold@users.noreply.git... (continued)

42 of 57 new or added lines in 1 file covered. (73.68%)

11 existing lines in 1 file now uncovered.

16735 of 28221 relevant lines covered (59.3%)

0.66 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
15
62.68
0.61% pkg/importer/vddk-datasource_amd64.go

Uncovered Existing Lines

Lines Coverage ∆ File
11
54.39
-4.6% cmd/openstack-populator/openstack-populator.go
Jobs
ID Job ID Ran Files Coverage
1 #5026.1 21 Nov 2024 11:55PM UTC 156
59.3
Source Files on build #5026
  • Tree
  • List 156
  • Changed 3
  • Source Changed 0
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • d57445ed on github
  • Prev Build on main
  • Next Build on main
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc