go-sql-driver / mysql / 11956769898

83%

Build Type

push

github

Committed by web-flow

Commit Message

Reduce "busy buffer" logs (#1641)

Reduce the use of `errBadConnNoWrite` to improve maintainability.

ResetSession() and IsValid() checks if the buffer is busy. This reduces
the risk of busy buffer error during connection in use. In principle,
the risk of this is zero. So I removed errBadConnNoWrite when checking
the busy buffer.

After this change, only `writePacke()` returns errBadConnNoWrite.

Additionally, I do not send COM_QUIT when readPacket() encounter read error.
It caused "busy buffer" error too and hide real errors.

Run Details

12 of 22 new or added lines in 3 files covered. (54.55%)

7 existing lines in 2 files now uncovered.

3132 of 3796 relevant lines covered (82.51%)

1387894.38 hits per line