mizosoft / methanol / #435

90%

master: 89%

Build Type

Pull #100

github

Committed by mizosoft

Commit Message

ByteChannelBodySubscriber touch-ups

 - Amongst other things, a race issue that lead the channel to read nothing
   when interrupted by another thread instead of throwing is fixed. This was
   caused by the implementation relying on AbstractInterruptibleChannel::end
   to detect interruption even if detected by waiting on BlockingQueue::take.
   This was not reliable as when a thread is interrupted, it first unparks
   parked threads, then calls the channel's interruption hook. This makes
   it possible for the interruption to be detected by the queue, but not
   yet by the channel (AbstractInterruptibleChannel::end). Now the channel
   throws a ClosedByInterruptionException when an InterruptedException is
   thrown by BlockingQueue::take.

 - Another notable change is that an upstream error is logged and not recorded
   if it is found that there is no way for the reader to notice it due to channel
   closure.

Pull Request Pull Request #100: ByteChannelBodySubscriber touch-ups

Run Details

109 of 117 new or added lines in 3 files covered. (93.16%)

140 existing lines in 20 files now uncovered.

7090 of 7746 relevant lines covered (91.53%)

0.92 hits per line