source-academy / backend / 5203125b39ec8db67efb51989a9fa8eae24b1a54

89%

Build Type

push

github

Committed by web-flow

Commit Message

Transfer groundControl (and admin panel) from staff to admin route (#1180)

* Create a new staff scope

* Move Admin Panel requests into admin scope

* Change appropriate routes into admin scope

* Find-replace galore

* Fix linting

* Linting does not work :(

* Revert "Find-replace galore"

This reverts commit e77aa0505.

* Revert "Change appropriate routes into admin scope"

This reverts commit 18dc689a4.

* Revert "Create a new staff scope"

This reverts commit 6b7e54e98.

* Move dangerous routes into a new scope

* Fix linting

* Linting works in mysterious ways

* One more formatting change

* Swap order of all-staff and admin-only routes

This swap prevents the all-staff route,
"/grading/:submissionid/:questionid", from pattern
matching and overshadowing the admin-only route
"/grading/:assessmentid/publish_all_grades". Thankfully, no admin routes
overshadow staff routes, so a quick fix can be done here.

* Update error message for grading routes

* Update error messages for users

* Add test cases for assets for staff

Create test cases to indicate that non-admin staff can only read assets,
but not create, modify, or delete them.

* Update test auth to admin for assets

* Update and add tests for course config routes

Updates positive test auth from staff to admin, adds negative tests to
ensure that non-admin staff are unable to read, update, create, or
delete course configs.

* Update and add tests for assessment-level routes

Update the modification / deletion test auth from staff to admin, and
create tests to ensure that non-admin staff are not able to delete /
unpublish them

* Fix sourcecast error

* Revert "Fix sourcecast error"

This reverts commit 831ca601d.

* Transfer asset routes to admin

* Revert accidental formatting changes

Run Details

9 of 9 new or added lines in 1 file covered. (100.0%)

4 existing lines in 2 files now uncovered.

3103 of 3313 relevant lines covered (93.66%)

1065.55 hits per line