rust-bitcoin / rust-bitcoin / 11861567618

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3611: Hashes: Make `hex` dependency optional

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/ec06028f63ba591a14c3a15cdfd410bb5ff1c09b">ec06028f6<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d32422cdb7ff721cdb566427cadc261b1b7d8351"> hashes: Make hex dependency optional (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/9dce0b4b8c6c905fa09585c0814e09b1bdf599b0">9dce0b4b8</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d32422cdb7ff721cdb566427cadc261b1b7d8351"> Remove hex string trait bounds from GeneralHash (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/766f498b33873dc6d66dd5d013cd400050161501">766f498b3</a> Pull serde stuff out of impl_bytelike_traits macro (Tobin C. Harding)

Pull request description:

  This is done in 3 parts:

  1. Pull the `serde` stuff out of `impl_bytelike_traits` to fix the bug described here: https://github.com/rust-bitcoin/rust-bitcoin/issues/2654#issuecomment-2470716693
  2. Prepare the `hashes` trait by removing string/hex trait bounds from `GeneralHash` and also pull the hex/string stuff out of `impl_bytelike_traits`
  3. Make hex optional, including adding custom debug logic when `hex` feature is not enabled

  Patch 3 is tested in `hashes/embedded`, by the new `debug` unit test, and there is a `Midstate` unit test as well that covers the `Debug` impl.

  Close: #2654 - BOOM!

ACKs for top commit:
  apoelstra:
    ACK ec06028f63ba591a14c3a15cdfd410bb5ff1c09b; successfully ran local tests; nice!

Tree-SHA512: 85eb10d360e986490670a9e23f09be57466

29 of 30 new or added lines in 3 files covered. (96.67%)

20005 of 24229 relevant lines covered (82.57%)

17969.97 hits per line