SAP / ui5-linter / 11855659814

86%

push

github

fix(Test Starter Configs): Fix false-positive findings (#409)

This fixes a false-positive finding of the property `theme` inside
[Configuration.beforeBootstrap.qunit.js](https://github.com/SAP/openui5/blob/master/src/sap.ui.core/test/sap/ui/core/qunit/bootstrap/Configuration.beforeBootstrap.qunit.js).
This resulted in undefined runtime errors.
`theme` should only be checked for Test Starter configs. 

Changes:
* Now, the **file name** is checked against a Regex and optional
chaining was optimized to prevent these runtime errors further.

* A sample `Configuration.beforeBootstrap.qunit.js` was added as a test
artifact. As seen in the snapshots, there are no more findings for this
file.

* In the course of adding a Regex check for the file name,
`testsuite2.qunit.js` was renamed to
`testsuite.special-case-quotes.qunit.js` to be aligned with framework
functionality.

1895 of 2440 branches covered (77.66%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

2719 of 3182 relevant lines covered (85.45%)

2650.59 hits per line