safe-global / safe-client-gateway / 11852718203

89%

main: 89%

Pull #2131

github

fix: swagger factory type can’t be null

The factory address is being set as AddressInfo | null. I think that it
in practice it is impossible for the factory to be null.

If we look at the transaction mapping in
src/routes/transactions/entities/transfer-transaction-info.entity.ts

We can see that the factory is set to
await this.addressInfoHelper.getOrDefault(…). The getOrDefault function
always returns an Address. More, the mapTransaction sets the transaction
as a CreationTransaction type. If we look at the zod schema:
export const CreationTransactionSchema = z.object({
…
  factoryAddress: AddressSchema,
…
});

So the zod defintion to the CreationTransaction is also an address.

Because of this I’ve changed the tx type generated by Swagger to be
only AddressInfo.

2712 of 3376 branches covered (80.33%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

9098 of 9825 relevant lines covered (92.6%)

428.25 hits per line