chartjs / chartjs-plugin-zoom / 11843727210

89%

push

github

Fix "original" scale limits with nonlinear pan (#774)

* Add some JSDoc types

These currently raise spurious errors, due to limitations in Chart.js types.

* Fix handling of "original" with panning nonlinear scales

Nonlinear scales failed to resolve "original" within panNumericalScale.

To fix this:

* Resolving "original" within panNumericalScale seemed redundant, when
  updateRange was already doing it, so I instead moved the logic into
  updateRange and control it with a new special value for the `zoom`
  parameter.  (Hopefully the use of a special string like this is
  acceptable as long as JSDoc calls it out - if I should use another
  approach, please let me know.)
* This change put updateRange over the configured ESLint complexity
  limit, so I extracted a new getScaleLimits function to reduce
  complexity.

Add unit tests, both for this bug and for the preexisting but untested
"original" feature.

* Upgrade Chart.js to fix type errors

264 of 329 branches covered (80.24%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

420 of 486 relevant lines covered (86.42%)

1416.52 hits per line