safe-global / safe-smart-account / 11841078372

94%

push

github

Assembly Memory Safety (#859)

This PR does a once-over on memory Safety for the 1.5.0 contracts. In
particular, there were a couple of missing `memory-safe` tags for some
assembly blocks which were preventing the IR assembler from working
correctly.

Additionally, since the `MultiSend*` contracts changed anyway in 1.5.0,
I took this opportunity to change the assembly to be memory-safe so that
we can tag it. Note that it only adds more code in the revert case, so
it should not have a negative impact for most use-cases.

Furthermore, I added a comment explaining why we did not make the
`SafeProxy` contract memory-safe (that is one intentional).

Lastly, I noticed that there were some `eq(..., 0)` assembly calls which
can be written as `iszero(...)` to save some gas and code. Again, it was
an opportunistic change as the affected contracts have changed anyway
and will be re-audited.

---------

Co-authored-by: Shebin John <admin@remedcu.com>

324 of 366 branches covered (88.52%)

Branch coverage included in aggregate %.

495 of 507 relevant lines covered (97.63%)

100.25 hits per line