unicode-org / icu4x / 11832307727

75%

Build Type

push

github

Committed by web-flow

Commit Message

Reduce stack size of DecimalSymbolsV1 (#5804)

Fixes https://github.com/unicode-org/icu4x/issues/4437


This doesn't work yet: there's no easy way to get Bake impls for custom
VarULE types since `from_byte_slice_unchecked` can't be called in const
contexts (since you can't do trait stuff in non-const contexts: in
theory this function is very const-capable)

I chose to use `make_varule` but VarTupleNULE would work as well (and
plus we can give it the relevant Bake impl if we want). I wrote this PR
to encapsulate things so that swapping the internals is easier

I think I'll make this work by implementing ZeroCow:
https://github.com/unicode-org/icu4x/issues/5561


<!--
Thank you for your pull request to ICU4X!

Reminder: try to use [Conventional
Comments](https://conventionalcomments.org/) to make comments clearer.

Please see
https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for
general
information on contributing to ICU4X.
-->

Run Details

73 of 97 new or added lines in 8 files covered. (75.26%)

17 existing lines in 4 files now uncovered.

54412 of 72267 relevant lines covered (75.29%)

655123.4 hits per line