11826508344
78%
master: 79%

Ran 13 Nov 2024 09:59PM UTC

Jobs 0

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 11826508344

Build Type

push

github

Committed by

jrfnl

Commit Message

Common::getSniffCode(): be more lenient about sniffs not following naming conventions

Sniff classes _should_ always follow the directory layout and naming conventions for sniffs as per the [Tutorial](https://github.com/PHPCSStandards/PHP_CodeSniffer/wiki/Coding-Standard-Tutorial).

However, before the change made in 524, when given a sniff class name for a sniff not following the naming conventions, the `Common::getSniffCode()` method would return a "sniff code" anyway. And even though the sniff code would be unconventional and not really valid, it would still _work_.

Since 524 this is no longer the case.

Given the above, the change from 524 breaks custom rulesets which use `<rule>` includes for individual sniff files not complying with the naming conventions. Breaking changes can only be made in majors, so this commit reverts the problematic part of the change from 524.

Includes additional tests safeguarding the (broken) behaviour which needs to be maintained until the next major.

Fixes 675

Run Details

Source Files on build 11826508344

Detailed source file information is not available for this build.

PHPCSStandards / PHP_CodeSniffer / 11826508344
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on build 11826508344

PHPCSStandards / PHP_CodeSniffer / 11826508344 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on build 11826508344

PHPCSStandards / PHP_CodeSniffer / 11826508344
78%
master: 79%

README BADGES
x