rust-bitcoin / rust-bitcoin / 11822813449

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3576: transaction: Add plural field getters

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/be553217f19069dd9ca28c3ba5953059df9caa1b">be553217f transaction: Add plural field getters (Tobin C. Harding)

Pull request description:

  The `Transaction` type was created way back when, and the field names were named using singular (`input` and `output`). In hindsite plural probably should have been used since its more idiomatic Rust but the fields have been around so long now that re-naming them is going annoy a whole bunch of people.

  As a compromise add getters that use plural, immutable and mutable versions, for both the `input` and `output` fields.

  Close: #822

ACKs for top commit:
  apoelstra:
    ACK be553217f19069dd9ca28c3ba5953059df9caa1b; successfully ran local tests; though will let this sit a couple days before merging
  sanket1729:
    ACK be553217f19069dd9ca28c3ba5953059df9caa1b

Tree-SHA512: 4df9db1797e2a174dbf78600ae16a508764

0 of 4 new or added lines in 1 file covered. (0.0%)

19773 of 23976 relevant lines covered (82.47%)

18128.53 hits per line