babelfish-for-postgresql / babelfish_extensions / 11796565542

73%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Fix date functions to take into account the timezone setting (#2918) (#3099)

Issues -

When the timezone parameter group setting is set to something other than the default UTC, Babelfish date
related functions like SYSDATETIME(), SYSDATETIMEOFFSET(), GETDATE() and CURRENT_TIMESTAMP don't take it
into account, while they should. The same issue occurs with a session-level timezone parameter.
SYSDATETIMEOFFSET() function returns datetimeoffset which does not store timezone due to incorrect casting
function.

Changes made to fix the issues -

Added appropriate CAST from TIMESTAMP to respective return types of date functions to ensure proper accounting for
timezone setting. Added timestamptz_datetimeoffset function for converting timestamp with time zone to
datetimeoffset. It ensures to store timezone property similar to timestamptz_datetime2 and timestamptz_datetime
functions.

Task: BABEL-5069

Signed-off-by: Anikait Agrawal <agraani@amazon.com>

Run Details

17 of 20 new or added lines in 3 files covered. (85.0%)

3 existing lines in 1 file now uncovered.

42345 of 57906 relevant lines covered (73.13%)

122267.21 hits per line