lightningnetwork / lnd / 11792129593

68%

master: 65%

Build Type

Pull #9258

github

Committed by yyforyongyu

Commit Message

chainntnfs: make sure notification is sent to the whole set

This commit fixes a bug where the confirmation details may be missed.
When the same tx is subscribed via `RegisterConfirmationsNtfn`, we will
put them into the same set and notify the whole set. However, this logic
is missing when performing the rescan - once the confirmation detail is
found, we only notify the current subscriber. Later we will skip
notifying other subscribers in `UpdateConfDetails` due to the
`confSet.details != nil` check. We now fix it by immediately notify all
the subscribers when the confirmation detail is found during the rescan.

Pull Request Pull Request #9258: chainntnfs: fix missing notifications

Run Details

38 of 46 new or added lines in 5 files covered. (82.61%)

61 existing lines in 10 files now uncovered.

132179 of 224395 relevant lines covered (58.9%)

19659.02 hits per line