• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

c-ares / c-ares / 11757190407
92%
main: 92%

Build:
Build:
LAST BUILD BRANCH: bhouse.qnx
DEFAULT BRANCH: main
Ran 09 Nov 2024 02:59PM UTC
Jobs 1
Files 178
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

09 Nov 2024 02:56PM UTC coverage: 91.235% (+0.03%) from 91.206%
11757190407

push

github

bradh352
Some upstream DNS servers are non-compliant with EDNS options

Some DNS servers don't properly ignore unknown EDNS options as the spec says they must, and instead will return EFORMERR.

See discussion roughly starting here: https://github.com/alpinelinux/docker-alpine/issues/366#issuecomment-2462530681

In this case the DNS server is known to support EDNS in general (as version prior to c-ares 1.33 worked which used EDNS), but when adding the EDNS DNS Cookie extension, they return EFORMERR.  This is in violation of [RFC6891 6.1.2](https://datatracker.ietf.org/doc/html/rfc6891#section-6.1.2):
> Any OPTION-CODE values not understood by a responder or requestor MUST be ignored.

The server in this example actual echo's back the EDNS record further causing confusion that makes you think they might understand the record.

We need to catch an EFORMERR and re-attempt the query without EDNS completely since they are really non-compliant with EDNS.  We may support additional EDNS extensions in the future and don't want to have to probe each individual extension with a braindead server.

Fixes #911
Authored-By: Brad House (@bradh352)

32 of 34 new or added lines in 2 files covered. (94.12%)

8 existing lines in 2 files now uncovered.

22089 of 24211 relevant lines covered (91.24%)

11960.77 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
83.56
0.14% src/lib/ares_process.c

Uncovered Existing Lines

Lines Coverage ∆ File
1
94.56
-0.42% src/lib/ares_init.c
7
91.74
0.08% src/lib/event/ares_event_thread.c
Jobs
ID Job ID Ran Files Coverage
1 11757190407.1 09 Nov 2024 02:59PM UTC 939
59.57
GitHub Action Run
Source Files on build 11757190407
  • Tree
  • List 178
  • Changed 126
  • Source Changed 0
  • Coverage Changed 58
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • efd32725 on github
  • Prev Build on v1.34 (#11745809390)
  • Next Build on v1.34 (#11757686366)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc