c-ares / c-ares / 11745806869

92%

push

github

ares_getaddrinfo() for AF_UNSPEC should retry if ipv6 received

We added an optimization to stop retries on other address classes
on failures if one address class was received successfully.  In
production, however, some odd misconfigured use cases could mean
an ipv6 address would be returned but the host was really only
capable of connecting to ipv4 machines.

We want to modify this optimization now to continue retries on
ipv4 even if ipv6 was received, but NOT the other way around.
It was always more likely that ipv6 resolution would cause the
delays due to system issues, as the world still really only
runs on ipv4...

Authored-By: Brad House (@bradh352)

56 of 56 new or added lines in 2 files covered. (100.0%)

22064 of 24186 relevant lines covered (91.23%)

11863.08 hits per line