unicode-org / icu4x / 11728132731

73%

Build Type

push

github

Committed by web-flow

Commit Message

Audit datetime format function (#5789)

I've found several bugs:
* `FieldLength::TwoDigit` truncates the number, which is incorrect. Only
the `yy` and `YY` patterns require truncation. I've moved this code to
the year branch, and renamed the variant `Two`
* `c..cc` and `e..ee` require locale-sensitive day-of-week-number
calculations, so they are now rejected during data loading
* `FieldLength::{Abbreviated, Wide, Narrow}` also apply to numeric
fields, where they mean 3, 4, 5. I renamed them and updated
documentation.
* Cyclic year names should be loaded from data (#3761)

Run Details

297 of 366 new or added lines in 15 files covered. (81.15%)

19 existing lines in 11 files now uncovered.

54328 of 72194 relevant lines covered (75.25%)

657720.22 hits per line