jcronenberg / agama / 11703250579

63%

Build Type

push

github

Committed by web-flow

Commit Message

feat(rust): adapt to zbus 5 (#1716)

## The main goal

Although [zbus 5](https://github.com/dbus2/zbus/releases/tag/zbus-5.0.0)
5 was released a few days ago, Agama is still using zbus 3. The goal of
this PR is to adapt the code to use the latest version.

However, this task is not trivial: version 4 already introduced a good
share of breaking changes in zbus API.

## `downcast_ref` returns `Result`

The `downcast_ref` function now returns a `Result` instead of an
`Option` with, IMHO, it is the right thing to do. This change has a big
impact in our code to interact with NetworkManager, so I took the
opportunity to:

* Distinguish between a problem and a missing value (we always returned
`None` when something went wrong).
* Use `get_property` and `get_optional_property` to simplify our code a
bit.

## Other changes

- Do some refactoring and organization of D-Bus proxies.
- Improve the `network::nm::dbus` module. Let's use `get_property` and
`get_optional_property` for better readability and error handling.
Please, check [this commit
(WIP)](https://github.com/agama-project/agama/commit/c21eda839)
if you are interested in further improvements.
- Drop some unused code.

Run Details

1766 of 2613 branches covered (67.59%)

Branch coverage included in aggregate %.

149 of 268 new or added lines in 23 files covered. (55.6%)

586 existing lines in 17 files now uncovered.

23565 of 32327 relevant lines covered (72.9%)

41.98 hits per line