rust-bitcoin / rust-bitcoin / 11674551027

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3539: Improve the `amount` module

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/81d8699b55dad570247cb14d2b3eea64270a83cf">81d8699b5<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3b0cb0e87d2b36c76cc5ce382a07e3e9f58e0b05"> units: Put no_std up top (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3e332c38398a017762a8a83eaf34a6e2ed8bd116">3e332c383</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3b0cb0e87d2b36c76cc5ce382a07e3e9f58e0b05"> amount: Fix docs on FromStr (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5bec76aa51c3183c20165ee5af892b8d057a3da8">5bec76aa5</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3b0cb0e87d2b36c76cc5ce382a07e3e9f58e0b05"> amount: Fix rustdocs (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/41c80cc476477facf028bda566465c61a8256d7e">41c80cc47</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3b0cb0e87d2b36c76cc5ce382a07e3e9f58e0b05"> amount: Improve docs on div by weight (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2b4a61739ae2e9d46b54bdb665a749f0c8b4234e">2b4a61739 Add type to debug output for Amount (Tobin C. Harding)
42e5043b3 Add from_int_btc group of functions (Tobin C. Harding)

Pull request description:

  Improve the `amount` module by doing:

  - Patch 1: Add/update `from_int_btc` and `from_int_btc_const` functions
  - Patch 2:  Add type to debug output for `Amount`
  - Patch 3: Fix incorrect docs
  - Patch 4: Make docs use correct style and be uniform across the two amount types
  - Patch 5: Fix docs on `FromStr`

ACKs for top commit:
  apoelstra:
    ACK 81d8699b55dad570247cb14d2b3eea64270a83cf; successfully ran local tests
  jamillambert:
    ACK 81d8699b55dad570247cb14d2b3eea64270a83cf

Tree-SHA512: ddd6e02b4002ef0c6d4f321e3bf6c1c2a4c

3 of 27 new or added lines in 3 files covered. (11.11%)

19695 of 23903 relevant lines covered (82.4%)

18195.38 hits per line