Ouranosinc / xscen / 11670141241

90%

push

github

Add tests to `aggregate.py` (#486)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [ ] CHANGELOG.rst has been updated (with summary of main changes).
- [ ] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* Mainly, this adds tests to the lines in `aggregate.py` that had yet to
be tested.
* Bugfix: `climatological_op` now correctly handles `kwargs`.
* Bugfix: `climatological_op` with `linregress` now correctly handles
`min_periods`
* Removed obsolete code now that we pin `xarray >=2023.11`.
* Bugfix: `datablock_3d` did not use the same attributes for the rotated
pole when creating the fake dataset.

### Does this PR introduce a breaking change?
* `method=='interp_centroid'` in `spatial_mean` has been removed without
backwards compatibility or staged removal, since it could produce vastly
erroneous results.
* Not really breaking since the function was not public, but
`regrid._get_grid_mapping` was moved to `spatial.py` and made public.


### Other information:

59 of 63 new or added lines in 3 files covered. (93.65%)

3650 of 4408 relevant lines covered (82.8%)

4.86 hits per line