Ouranosinc / xscen / 11668951593

90%

push

github

Follow CF convention for temperature difference (#429)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #428
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* Add unit_metadata for the dtr conversion to be clear that this is a
difference and not convert the units in a non-sensical way.
* Added unit update for delta. If it's a temperature xclim will add the
unit_metadata. Do we want this for the climatological delta ?

### Does this PR introduce a breaking change?
yes, changes the attrs

### Other information:
* this needs to wait for the next xclim release for the new functions. 
* Should we add `temperature: on_scale` for `tasmax_from_dtr` and
`tasmin_from_dtr` or is it unecessary?
* Is it necessary somewhere else ?

6 of 6 new or added lines in 2 files covered. (100.0%)

3587 of 4406 relevant lines covered (81.41%)

4.79 hits per line