ocaml / dune / 28911

7%

Build Type

push

github

Committed by web-flow

Commit Message

pkg: Use `filtered_formula` to represent dependencies (#10918)

* pkg: Pass-through `filtered_formula` from opam files to solver

The `Dependency_set.t` representation can't deal with disjunctions but
in most cases that is not even necessary as the set gets turned into a
`filtered_formula` again. Thus it might be easier to keep the original
representation and implement the necessary dependency set functionality
on top of that.

Signed-off-by: Marek Kubica <marek@tarides.com>

* Remove unused `Dependency_set`

Signed-off-by: Marek Kubica <marek@tarides.com>

* Add a test showing that the disjunction in OPAM files is supported now

Signed-off-by: Marek Kubica <marek@tarides.com>

* Move `filtered_formula` into our own module

Signed-off-by: Marek Kubica <marek@tarides.com>

* Determine the hash from the Sexp

Signed-off-by: Marek Kubica <marek@tarides.com>

* Move reachability into the formula

Signed-off-by: Marek Kubica <marek@tarides.com>

* Add test for dependency formula changes

Signed-off-by: Marek Kubica <marek@tarides.com>

* Clean up the awkward API

Signed-off-by: Marek Kubica <marek@tarides.com>

* Promote expected hash changes

Signed-off-by: Marek Kubica <marek@tarides.com>

* Update the test wording and show the difference

Signed-off-by: Marek Kubica <marek@tarides.com>

* test(pkg): demonstrate unreachable packages being included

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Signed-off-by: Marek Kubica <marek@tarides.com>

* Do not include post dependencies in reachable packages

Signed-off-by: Marek Kubica <marek@tarides.com>

* Replace sexp by dyn

Signed-off-by: Marek Kubica <marek@tarides.com>

* Promote expected hash changes

Signed-off-by: Marek Kubica <marek@tarides.com>

* `post` deps are excluded now

Signed-off-by: Marek Kubica <marek@tarides.com>

* Simplify

Signed-off-by: Marek Kubica <marek@tarides.com>

* Use `Resolve_opam_formula` to determine depe... (continued)

Run Details

0 of 58 new or added lines in 6 files covered. (0.0%)

4 existing lines in 3 files now uncovered.

2933 of 42427 relevant lines covered (6.91%)

26850.21 hits per line