rust-bitcoin / rust-bitcoin / 11644180478

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2861: Introduce `impl_bytelike_traits` macro

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/90b2ac03e3560b0e9f78f52b198c869773b5816e">90b2ac03e hashes: Introduce impl_bytelike_traits macro (Tobin C. Harding)

Pull request description:

  We have a couple of problems:

  1. There are two macros currently for fmt stuff that do similar things, `arr_newtype_fmt_impl` and `hex_fmt_impl` - the difference is not immediately obvious, its the way that the byte array is iterated.

  2. Our hash types are missing `AsRef<[u8; len]>` and `Borrow<[u8; len]>`.

  Introduce a new macro and remove a bunch of other macros. Include extensive docs but hide the macro from public docs because its not really for consumers of the library.

  The macro requires `$crate::hex` to point to `hex-conservative`.

  Note the macro is pretty generic (as in general purpose), `hashes` might not be the right home for it. Potentially a better place would be in `hex` itself?

ACKs for top commit:
  apoelstra:
    ACK 90b2ac03e3560b0e9f78f52b198c869773b5816e; successfully ran local tests

Tree-SHA512: 4d8778c578f1269d28e7236ac656347f75d

15 of 16 new or added lines in 2 files covered. (93.75%)

19696 of 23865 relevant lines covered (82.53%)

18253.74 hits per line