skeema / skeema / 11637880216

92%

push

github

docker: allow tmpfs on Mac/Windows; use smaller redo logs

This commit makes two performance improvements affecting workspace=docker, as
well as Skeema's integration test suites:

* Previously, when using docker-cleanup=destroy, the container would use a
  tmpfs mount automatically only on a native Linux host. This was due to a
  common misinterpretation of the Docker docs; tmpfs actually is also usable
  on Docker Desktop for MacOS or Windows. This is now fixed, and likewise for
  a few integration tests which can now leverage tmpfs on any host OS.

* InnoDB redo logs for new containers are now set to their minimum allowed
  value of 4mb. Ordinarily, this could be problematic on MySQL 8+ even for a
  DDL-only workload on throwaway ephemeral container, because DDL in MySQL 8+
  writes to the InnoDB-based data dictionary. However, this is now doable
  because the previous commit ca85df7 disables redo logging in MySQL 8+ for
  Skeema's workspace containers and integration test containers. Meanwhile,
  MySQL 5.x and MariaDB (any version) use frm files, so Skeema's DDL
  workload won't be constrained by a tiny redo log.

The second change is primarily included here because it reduces memory usage
when operating on tmpfs from the first change.

3 of 3 new or added lines in 1 file covered. (100.0%)

10058 of 10786 relevant lines covered (93.25%)

1.11 hits per line