Qiskit / qiskit / 11634403304

88%

Build Type

push

github

Committed by web-flow

Commit Message

Fix performance regression in looped `QuantumCircuit.assign_parameters` (#13337)

* Fix performance regression in looped `QuantumCircuit.assign_parameters`

When calling `assign_parameters` on a heavily parametric circuit with
the unusual access pattern of binding off a single parameter at a time,
Qiskit 1.2 had a severe performance regression compared to Qiskit 1.1
stemming from gh-12794.  The calls to `unsorted_parameters` on each
iteration were creating a new `set`, which could be huge if the number
of parameters in the circuit was large.  In Qiskit 1.1 and before, that
object was a direct view onto the underlying `ParameterTable` (assuming
the input circuit did not have a parametric global phase), so was free
to construct.

* Improve documentation

Run Details

16 of 17 new or added lines in 2 files covered. (94.12%)

11 existing lines in 3 files now uncovered.

76355 of 86066 relevant lines covered (88.72%)

358776.78 hits per line