rust-bitcoin / rust-bitcoin / 11622287991

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3544: Favour `to_vec` over `to_bytes`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/a51768af3f3d4c8e138e1ded250800810bedc903">a51768af3<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/4c8347a7ac4e382d3ae562fed1bea7547cba435e"> key: Deprecate to_bytes (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3af3239ad03d52dd7b58dba293e2ff991bf8cb96">3af3239ad</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/4c8347a7ac4e382d3ae562fed1bea7547cba435e"> script: Re-order functions (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/db40297f873d23e4bce164c0f06778fd535c67a2">db40297f8</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/4c8347a7ac4e382d3ae562fed1bea7547cba435e"> script: deprecate to_bytes (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c5cd0db493b3d4427ff3c6c5b8433c217e7e195b">c5cd0db49</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/4c8347a7ac4e382d3ae562fed1bea7547cba435e"> Revert the change to to_bytes (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/dc2ca785d28067d33da10413fc4e5adc24bb7ea4">dc2ca785d</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/4c8347a7ac4e382d3ae562fed1bea7547cba435e"> Add to_vec and deprecate to_bytes for array types (Tobin C. Harding)
a6b7ab32a Move impl_array_newtype to internal_macros (Tobin C. Harding)

Pull request description:

  Use `to_vec` and deprecate `to_bytes`, the opposite of what we did in #2585.

  For functions that return a `Vec` by first allocating use function name `to_vec`. This explicitly excludes:

  - Functions that return an array (`CompressedPublicKey::to_bytes`)
  - Functions that consume self and return a `Vec` without allocating (`ScriptBuf::into_bytes`)

  See #3025 for discussion and consensus.

  Close: #3025

ACKs for top commit:
  apoelstra:
    ACK a51768af3f3d4c8e138e1ded250800810bedc903; successfully ran local tests

Tree-SHA512: ee932c13a7f56e6739594457b3c4e5dacf8

28 of 61 new or added lines in 11 files covered. (45.9%)

19734 of 23921 relevant lines covered (82.5%)

18194.63 hits per line