Qiskit / qiskit / 11613885904

88%

Build Type

push

github

Committed by web-flow

Commit Message

Deprecate the condition attribute and related functionality (#13223)

* Deprecate the condition attribute and related functionality

This commit deprecates the Instruction.condition and c_if() method for
removal in 2.0. This functionality has been superseded by the more
sophisiticated `IfElseOp` for some time now. Removing the condition
property will simplify the Qiskit data model as it is implemented in
a kind of ad-hoc manner that adds additional overhead to manually check
it in many places.

For the unittest modifications the deprecation warning for the .condtion
getter is suppressed for the entire suite because this gets triggered
internally by the transpiler and a lot of other places, including from
rust code as until it is removed we need to use it to check that piece
of the data model.

Fixes #9556

* Add missing assertWarns

* Handle deprecation warnings in visual tests too

* Apply suggestions from code review

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>

* Use private attribute in py->rust conversion

* Avoid deprecation warning in non-deprecated code

This commit fixes some places in the code where we were using the
deprecated functionality where it needed a path to persist the behavior
or where the deprecation warning became a performance bottleneck. The
code is updated accordingly and to catch issues like this in the future
the warning filters are adjusted to be more selective.

* Add missing test updates

* Add filter for aer's condition usage and dag drawer

* Fix lint

---------

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>

Run Details

81 of 83 new or added lines in 29 files covered. (97.59%)

5 existing lines in 1 file now uncovered.

75991 of 85628 relevant lines covered (88.75%)

363350.77 hits per line