rust-bitcoin / rust-bitcoin / 11602161408

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#3510: Move `Transaction` to `primitives`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/f8f846bb9ea3cfde460ec058eb04e5aba010cdbb">f8f846bb9<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c2adc52ee1a16136ee0648bbf80343a119be0311"> Move Transaction type to primitives (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/7b5af2ad5bce6b519df6646ed341a59dab602b8b">7b5af2ad5</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c2adc52ee1a16136ee0648bbf80343a119be0311"> Use `Transaction::compute_txid` in rustdoc (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/98383a0fbed96debc4b7348abf63f87acc7e7cac">98383a0fb</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c2adc52ee1a16136ee0648bbf80343a119be0311"> Introduce Transaction extension traits (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3f6bc74ae48b984f427a91a98a672aaeedb7b684">3f6bc74ae</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c2adc52ee1a16136ee0648bbf80343a119be0311"> Introduce an iterator type for script_pubkey_lens (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/7196992d589785e8fd408f70bd5384f16b271c90">7196992d5 Split Transaction impl block (Tobin C. Harding)
693000d09 Use super::* in bench module (Tobin C. Harding)
29d23b4b3 Move import statement (Tobin C. Harding)
e84346644 Run the formatter (Tobin C. Harding)

Pull request description:

  First introduce the `Transaction` extension traits manually (without using the `define_extension_trait` macro) then move the `Transaction` to `primitives`.

  Note please patch 5, ugly due to language requirements.

ACKs for top commit:
  apoelstra:
    ACK f8f846bb9ea3cfde460ec058eb04e5aba010cdbb; successfully ran local tests

Tree-SHA512: f830ad4f7be2c0b6bac939f420555d2f40d

Coverage Stats

131 of 167 new or added lines in 4 files covered. (78.44%)

1 existing line in 1 file now uncovered.

19770 of 23933 relevant lines covered (82.61%)

18124.53 hits per line