unicode-org / icu4x / 11598557576

73%

Build Type

push

github

Committed by web-flow

Commit Message

Remove generic metazone values that match location values (#5751)

-100KB

Generic non-location format ("Central European Time", "Armenia Time")
falls back to location ("Zurich Time", "Armenia Time"), so we can remove
duplicates.

There are some entries that I feel should be deduplicated, but aren't
(metazone name listed first):
* The metazone name is more specific than the location name. This is
weird, because for the location format, the [region should be used if
there's only one time zone in the
country](https://www.unicode.org/reports/tr35/tr35-dates.html#Contents:~:text=From%20the%20TZDB%20get%20the%20country%20code%20for%20the%20zone%2C%20and%20determine%20whether%20there%20is%20only%20one%20timezone%20in%20the%20country.%20If%20there%20is%20only%20one%20timezone%20or%20if%20the%20zone%20id%20is%20in%20the%20%3CprimaryZones%3E%20list%2C%20format%20the%20country%20name%20with%20the%20regionFormat%2C%20and%20return%20it.).
We do this, but then the metazone exists and reverts that
  * `Apia Time` vs `Samoa Time`
  * `Pyongyang Time` vs `North Korea Time`
  * `Taipei Time` vs `Taiwan Time`
  * `Petropavlovsk-Kamchatski Time` vs `Kamchatka Time`
* The generic meta zone includes "standard". This is a data issue, the
problem is probably that for non-DST metazones, the only entry is
`standard`, which might confuse linguists:
  * `Guam Standard Time` vs `Guam Time`
  * `Singapore Standard Time` vs `Singapore Time`
* The match is not perfect. Some of this data definitely needs to be
cleaned up, but others might be fixed by using a different region
display name in datagen.
  * `Brunei Darussalam Time` vs `Brunei Time`
  * `Cocos Islands Time` vs `Cocos (Keeling) Islands Time`
  * `Dumont-d’Urville Time` vs `Dumont d’Urville Time`
  * `East Timor Time` vs `Timor-Leste Time`
  * `Easter Island Time` vs `Easter Time`
  * `Fernando de Noronha Time` vs `Noronha Time`
* `French Southern & Antarctic Time` vs `French Southern Territo... (continued)

Run Details

142 of 164 new or added lines in 2 files covered. (86.59%)

2 existing lines in 2 files now uncovered.

54250 of 72105 relevant lines covered (75.24%)

652191.79 hits per line